[PATCH] D157813: [VE][Clang] Change to enable VPU flag by default
Fangrui Song via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Aug 14 23:33:27 PDT 2023
MaskRay added inline comments.
================
Comment at: clang/include/clang/Driver/Options.td:5169
+ HelpText<"Emit VPU instructions for VE">;
+def mno_vevpu : Flag<["-"], "mno-vevpu">, Group<m_ve_Features_Group>,
+ HelpText<"Do not emit VPU instructions for VE">;
----------------
In general, we just need documentation for the non-default option (let's say `-mvevpu`). Documentation for the opposite `-mno-mvevpu` is just boilerplate and not very useful.
================
Comment at: clang/test/Driver/ve-features.c:1
+// RUN: %clang -target ve-unknown-linux-gnu -### %s -mvevpu 2>&1 | FileCheck %s -check-prefix=VEVPU
+// RUN: %clang -target ve-unknown-linux-gnu -### %s -mno-vevpu 2>&1 | FileCheck %s -check-prefix=NO-VEVPU
----------------
`-target ` has been deprecated since Clang 3.4. Use `--target=`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157813/new/
https://reviews.llvm.org/D157813
More information about the cfe-commits
mailing list