[PATCH] D157149: [Option] Add "Visibility" field and clone the OptTable APIs to use it
Petr Hosek via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Aug 14 16:51:44 PDT 2023
phosek added inline comments.
================
Comment at: llvm/include/llvm/Option/OptParser.td:153
class Flags<list<OptionFlag> flags> { list<OptionFlag> Flags = flags; }
+class Vis<list<OptionVisibility> vis> { list<OptionVisibility> Vis = vis; }
class Group<OptionGroup group> { OptionGroup Group = group; }
----------------
Would it be possible to spell this out in full, that is `Visibility` rather than `Vis`? It's more consistent with all other attributes and improves readability in my opinion.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157149/new/
https://reviews.llvm.org/D157149
More information about the cfe-commits
mailing list