[PATCH] D155610: [Clang][Sema] Fix display of characters on static assertion failure

Abhina Sree via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 14 12:57:01 PDT 2023


abhina.sreeskantharajan added a comment.

I've discussed offline with @hubert.reinterpretcast and agree with him that with the addition of fexec-charset support, the set of characters deemed printable will not be accurate when other encodings are used. This will be similar to the printf/scanf format string validation issue I mentioned in my RFC and would require us to reverse the conversion or keep the original string around to check if the character is printable. I don't think we have finalized a solution on how to handle these issues yet.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155610/new/

https://reviews.llvm.org/D155610



More information about the cfe-commits mailing list