[PATCH] D157280: [PGO] Enable `-fprofile-update` for `-fprofile-generate`

[Qiongsi Wu via Phabricator via cfe-commits]

qiongsiwu1 added inline comments.


================
Comment at: llvm/lib/Passes/PassBuilderPipelines.cpp:1797
       addPGOInstrPasses(MPM, Level, /* RunProfileGen */ true,
-                        /* IsCS */ true, PGOOpt->CSProfileGenFile,
-                        PGOOpt->ProfileRemappingFile,
+                        /* IsCS */ true, PGOOpt->AtomicCounterUpdate,
+                        PGOOpt->CSProfileGenFile, PGOOpt->ProfileRemappingFile,
----------------
MaskRay wrote:
> qiongsiwu1 wrote:
> > MaskRay wrote:
> > > The canonical way to specify the parameter name is `/*IsCS=*/true`
> > Ah thanks for pointing it out! Let me fix it in a later NFC patch if that is OK. There are quite a few changes required and they would make the actual feature harder to see. 
> I think it's better to fix the argument style while you are modifying it. Otherwise, there may not be not much value to do a batch change for this file.
> I think it's better to fix the argument style while you are modifying it. Otherwise, there may not be not much value to do a batch change for this file.

Ok sounds good. I will fix the comments relevant to this patch. Thanks! 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157280/new/

https://reviews.llvm.org/D157280