[PATCH] D156693: [clang][ASTImporter]Skip check depth of friend template parameter
    Qizhi Hu via Phabricator via cfe-commits 
    cfe-commits at lists.llvm.org
       
    Mon Aug 14 11:14:47 PDT 2023
    
    
  
jcsxky added inline comments.
================
Comment at: clang/lib/AST/ASTImporter.cpp:5831
+            FoundTemplate->getFriendObjectKind() != Decl::FOK_None &&
+            !D->specializations().empty();
+        if (IsStructuralMatch(D, FoundTemplate, true, IgnoreDepth)) {
----------------
balazske wrote:
> Probably add `IsFriendTemplate`?
I think this is not needed because D is not always a friend template class according to the testcase (IsFriendTemplate is false in testcase).
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156693/new/
https://reviews.llvm.org/D156693
    
    
More information about the cfe-commits
mailing list