[PATCH] D157479: [Clang][DebugInfo] Emit narrower base types for structured binding declarations that bind to struct bitfields

Mon Aug 14 10:17:41 PDT 2023

aprantl added inline comments.

================
Comment at: clang/test/CodeGenCXX/debug-info-structured-binding-bitfield.cpp:525
+// CHECK: !202 = !DILocation(line: 279, column: 8, scope: !194)
+// CHECK: !203 = !DILocation(line: 279, column: 17, scope: !194)
+// CHECK: !204 = !DILocation(line: 280, column: 1, scope: !194)
----------------
This test is going to to be a nightmare to maintain since it's hardcoding all the metadata numbering. Please use FileCheck variables `![[VAR:[0-9]+]]` to refer to other fields. Also, this test is probably checking too much.
The primary thing this patch changes is the data types of the fields, so the CHECK lines should focus on that.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157479/new/

https://reviews.llvm.org/D157479