[PATCH] D157362: [RISCV] Add MC layer support for Zicfilp.

[Philip Reames via Phabricator via cfe-commits]

reames added inline comments.


================
Comment at: llvm/docs/RISCVUsage.rst:120
      ``Zicboz``       Assembly Support
+     ``Zicfilp``      Assembly Support
      ``Zicntr``       (`See Note <#riscv-i2p1-note>`__)
----------------
This in the wrong place; this is not a ratified extension.  

You need to link to the right spec version as well.  This is particularly important here as this spec has gone through a ton of churn, and may still do so.  


================
Comment at: llvm/test/MC/RISCV/zicfilp-valid.s:17
+
+# CHECK-ASM-AND-OBJ: auipc zero, 22
+# CHECK-ASM: encoding: [0x17,0x60,0x01,0x00]
----------------
If the proper extension is provided to llvm-objdump, we really shouldn't be disassembling this as the auipc name, it should be the landing pad mnemonic.  

I think this is just the use of -m no-aliases above.  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157362/new/

https://reviews.llvm.org/D157362