[PATCH] D157080: [clangd] Symbol search includes parameter types for (member) functions

Nathan Ridge via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 14 09:21:05 PDT 2023


nridge added a comment.

I understood https://github.com/clangd/clangd/issues/1344 as being about `workspace/symbol` rather than `textDocument/documentSymbol`, though I see now that both are affected.

The analysis is a bit different for the two, though: unlike `DocumentSymbol`, the result types for `workspace/symbol` (LSP specifies two options, `SymbolInformation` or `WorkspaceSymbol`) do not have a `detail` field. So, for `workspace/symbol`, the issue would require a fix on the clangd side (or a change to LSP, I guess).

@sammccall, would you support adding the signature to the symbol name for `workspace/symbol`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157080/new/

https://reviews.llvm.org/D157080



More information about the cfe-commits mailing list