[PATCH] D154503: [Sema] Fix handling of functions that hide classes

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 14 00:40:45 PDT 2023


kadircet added a comment.

In D154503#4576481 <https://reviews.llvm.org/D154503#4576481>, @aaron.ballman wrote:

> In D154503#4576475 <https://reviews.llvm.org/D154503#4576475>, @kadircet wrote:
>
>> In D154503#4576442 <https://reviews.llvm.org/D154503#4576442>, @aaron.ballman wrote:
>>
>>> I'm not opposed to a revert if this is causing problems for your downstream, but be sure to also remove the changes from the 17.x branch if you go this route rather than fixing forward.
>>
>> Thanks! I didn't notice it made into the release branch. I'd wait for author's comment on this one, as I guess we can cherry-pick just the fix-forward if it turns out to be small and safe. Otherwise I am more than happy to request the cherry-pick for the revert.
>
> SGTM!

Requested cherry-pick in https://github.com/llvm/llvm-project/issues/64670


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154503/new/

https://reviews.llvm.org/D154503



More information about the cfe-commits mailing list