[PATCH] D154382: [ClangRepl] support code completion at a REPL

[Vassil Vassilev via Phabricator via cfe-commits]

v.g.vassilev added inline comments.


================
Comment at: clang/lib/Interpreter/CodeCompletion.cpp:1
+//===------ CodeCompletion.cpp - Code Completion for ClangRepl -------===//
+//
----------------
I would propose to rename this file to `InterpreterCodeCompletion.cpp` and implement the `Interpreter::codeComplete` interface. Then we can move all of the content of `ExternalSource.{h,cpp}`, `CodeCompletion.h` and `ExternalSource.h` in it. That will increase the encapsulation of the code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154382/new/

https://reviews.llvm.org/D154382