[PATCH] D157568: [clang-format] Handle NamespaceMacro string arg for FixNamespaceComments
Owen Pan via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun Aug 13 13:30:33 PDT 2023
owenpan added inline comments.
================
Comment at: clang/lib/Format/NamespaceEndCommentsFixer.cpp:177
llvm::Regex("^/[/*] *(end (of )?)? *(anonymous|unnamed)? *"
- "([a-zA-Z0-9_]+)\\(([a-zA-Z0-9:_]*)\\)\\.? *(\\*/)?$",
+ "([a-zA-Z0-9_]+)\\(([a-zA-Z0-9:_]*|\".+\")\\)\\.? *(\\*/)?$",
llvm::Regex::IgnoreCase);
----------------
HazardyKnusperkeks wrote:
> Maybe this?
I don't think we'd need it because the `+` is greedy.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157568/new/
https://reviews.llvm.org/D157568
More information about the cfe-commits
mailing list