[PATCH] D157767: [Driver] move Haiku header search path management to the driver

[Niels Sascha Reedijk via Phabricator via cfe-commits]

nielx added a comment.

I will test the patch and see if it works as expected. Note that we currently have the following preset header paths in our GCC port <https://github.com/haikuports/haikuports/blob/e707d89c2aaec2b12ed357cbf320b90279dabe50/sys-devel/gcc/patches/gcc-13.2.0_2023_08_10.patchset#L5447C1-L5487C28>.



================
Comment at: clang/lib/Driver/ToolChains/Haiku.cpp:58
+  addSystemInclude(DriverArgs, CC1Args, D.SysRoot + "/boot/system/develop/headers/os/app");
+  addSystemInclude(DriverArgs, CC1Args, D.SysRoot + "/boot/system/develop/headers/os/arch");
+  addSystemInclude(DriverArgs, CC1Args, D.SysRoot + "/boot/system/develop/headers/os/device");
----------------
Not (or no longer) in GCC default sys path, so can be removed.


================
Comment at: clang/lib/Driver/ToolChains/Haiku.cpp:86
+  addSystemInclude(DriverArgs, CC1Args, D.SysRoot + "/boot/system/develop/headers/glibc");
+  addSystemInclude(DriverArgs, CC1Args, D.SysRoot + "/boot/system/develop/headers/posix");
+  addSystemInclude(DriverArgs, CC1Args, D.SysRoot + "/boot/system/develop/headers");
----------------
Missing: /boot/system/develop/headers/gnu


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157767/new/

https://reviews.llvm.org/D157767