[PATCH] D156237: Complete the implementation of P2361 Unevaluated string literals

[Hubert Tong via Phabricator via cfe-commits]

hubert.reinterpretcast added inline comments.


================
Comment at: clang/test/Parser/c2x-attributes.c:29
+[[deprecated(L"abc")]] void unevaluated_string(void);
+// expected-warning at -1 {{encoding prefix 'L' on an unevaluated string literal has no effec}}
+
----------------
"Typo" fix.


================
Comment at: clang/utils/TableGen/ClangAttrEmitter.cpp:2336
 
+// Emits the list of arguments that shoulkd be parsed as unevaluated string
+// literals for each attributes
----------------
Typo fix


================
Comment at: clang/utils/TableGen/ClangAttrEmitter.cpp:2349
+      if (isVariadicStringLiteralArgument(Args[N])) {
+        for (; N < sizeof(uint32_t); N++)
+          Bits |= (1 << N);
----------------
barannikov88 wrote:
> maskTrailingZeros might also be useful
@cor3ntin, this comment appears unaddressed.

Additionally, (just for future reference) `++N` is suggested for the loop: https://llvm.org/docs/CodingStandards.html#prefer-preincrement.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156237/new/

https://reviews.llvm.org/D156237