[PATCH] D157104: [analyzer] Improve underflow handling in ArrayBoundV2

[Balázs Benics via Phabricator via cfe-commits]

steakhal accepted this revision.
steakhal added a comment.

Looks safe and good. I'm interested in the diff though.
Let me know once you have the results.
I wanna have a look before we land this.



================
Comment at: clang/lib/StaticAnalyzer/Checkers/ArrayBoundCheckerV2.cpp:184
+    // symbolic regions on the heap (which may be introduced by checkers that
+    // call SValBuilder::getConjuredHeapSymbolVal()) and non-symbolic regions
+    // (e.g. a field subregion of a symbolic region) in unknown space.
----------------
Such as the MallocChecker.


================
Comment at: clang/test/Analysis/out-of-bounds.c:176
 }
-
----------------
Try not to introduce unrelated hunks, as it might introduce more conflicts for downstream users than absolutely necessary.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157104/new/

https://reviews.llvm.org/D157104