[PATCH] D157708: [Sema] Suppress lookup diagnostics when checking reversed operators

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 11 05:45:58 PDT 2023


ilya-biryukov added inline comments.


================
Comment at: clang/lib/Sema/SemaOverload.cpp:967
                S.getScopeForContext(EqFD->getEnclosingNamespaceContext()));
   NonMembers.suppressAccessDiagnostics();
   for (NamedDecl *Op : NonMembers) {
----------------
I believe we should be able to expose the same errorenous behavior here, but I did not come up with a test yet, so did not change it yet.
We should update it and come up with a test before the change lands.

But I still wanted to get early feedback on the direction of this patch, so sending for review right away.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157708/new/

https://reviews.llvm.org/D157708



More information about the cfe-commits mailing list