[PATCH] D155978: [SPIRV] Add SPIR-V logical triple.

Fri Aug 11 05:30:01 PDT 2023

Keenuts marked an inline comment as done.
Keenuts added inline comments.

================
Comment at: llvm/include/llvm/TargetParser/Triple.h:106
+    wasm32,      // WebAssembly with 32-bit pointers
+    wasm64,      // WebAssembly with 64-bit pointers
     renderscript32, // 32-bit RenderScript
----------------
pmatos wrote:
> Keenuts wrote:
> > pmatos wrote:
> > > No need to reindent the whole block to add a single line.
> > IIRC it I did a clang-format because the buildbot complained the format was not right.
> > Reverted the clang-format commit (which seems better, I agree), and I'll see if the bots complains.
> I know what you did and it makes sense - I did the same myself while working on another backend but lets try not to change such a large amount of lines in a patch focused on something else. I think it's certainly better to propose this change in a single NFC patch if we think that clang-format output is better than the existing formatting.
Of course. So is the presubmit failure something we can ignore? Or shall I do another NFC patch to the format?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155978/new/

https://reviews.llvm.org/D155978