[PATCH] D157452: [RFC][Clang][Codegen] `std::type_info` needs special care with explicit address spaces

Matt Arsenault via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 10 14:51:23 PDT 2023


arsenm added inline comments.


================
Comment at: clang/lib/CodeGen/CGCall.cpp:5237-5238
+
+          if (VTy->isPointerTy() &&
+              VTy->getPointerAddressSpace() != IRTy->getPointerAddressSpace()) {
+            // In the case of targets that use a non-default address space for
----------------
you can also just unconditionally call CreateAddrSpaceCast and let it no-op if the types match


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157452/new/

https://reviews.llvm.org/D157452



More information about the cfe-commits mailing list