[PATCH] D157114: [clang][ASTImporter] Improve StructuralEquivalence algorithm on repeated friends

Ding Fei via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 10 08:47:59 PDT 2023


danix800 updated this revision to Diff 549059.
danix800 added a comment.

`CXXRecordDecl::friend_iterator` is actually a reversed iterator. Deduplication with
different iterator direction produces different result. ASTImporter uses forward iterator
so structural equivalence checking should be in consistent with that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157114/new/

https://reviews.llvm.org/D157114

Files:
  clang/lib/AST/ASTImporter.cpp
  clang/lib/AST/ASTStructuralEquivalence.cpp
  clang/unittests/AST/ASTImporterTest.cpp
  clang/unittests/AST/StructuralEquivalenceTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D157114.549059.patch
Type: text/x-patch
Size: 15560 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230810/e5f56b5e/attachment-0001.bin>


More information about the cfe-commits mailing list