[PATCH] D155290: [PGO] Use Unique Profile Files when New Processes are Forked

Thu Aug 10 06:11:22 PDT 2023

qiongsiwu1 added a comment.

In D155290#4574797 <https://reviews.llvm.org/D155290#4574797>, @MaskRay wrote:

> In D155290#4572965 <https://reviews.llvm.org/D155290#4572965>, @qiongsiwu1 wrote:
>
>> Ping for review.
>>
>> If there are no comments on whether we should add `-lpthread` for platforms other than AIX, I will land this patch soon, and let the official buildbots check for problems. If there are problems, I will let the bots run a bit (probably a day or so) before reverting to catch as many platforms I need to fix as possible, revert, and fix the patch.
>>
>> Thanks!
>
> I will take a look as well but please don't land this `-lpthread` change for non-AIX platforms. I will think about the implication.

Thanks @MaskRay ! I am putting this patch on hold till I hear back. The patch does not alter non-AIX platforms at the moment.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155290/new/

https://reviews.llvm.org/D155290