[PATCH] D157474: [RISCV] Add missing Xsfvcp extension check in clang sema

[Brandon Wu via Phabricator via cfe-commits]

4vtomat marked an inline comment as done.
4vtomat added inline comments.


================
Comment at: clang/test/Sema/rvv-required-features-invalid.c:16
+void test_sf_vc_x_se_u64m1(uint64_t rs1, size_t vl) { // expected-note {{'test_sf_vc_x_se_u64m1' declared here}}
+  __riscv_sf_vc_x_se_u64m1(1, 1, 1, rs1, vl); // expected-error {{call to undeclared function '__riscv_sf_vc_x_se_u64m1'}} expected-note {{did you mean 'test_sf_vc_x_se_u64m1'?}}
+}
----------------
craig.topper wrote:
> This doesn't mention the xsfvcp extension. So it doesn't look like the diagnostic in the code is being hit.
I guess it's just because `__riscv_sf_vc_x_se_u64m1` is too similar to `test_sf_vc_x_se_u64m1`, I just changed the name of the function, and the diagnostic just disappeared.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157474/new/

https://reviews.llvm.org/D157474