[PATCH] D157331: [clang] Implement C23 <stdckdint.h>

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added inline comments.


================
Comment at: clang/test/Headers/stdckdint.cpp:1
+// RUN: %clang_cc1 -emit-llvm -fgnuc-version=4.2.1 -std=gnu++11 %s -o - | FileCheck %s
+
----------------
hiraditya wrote:
> aaron.ballman wrote:
> > ZijunZhao wrote:
> > > enh wrote:
> > > > ZijunZhao wrote:
> > > > > enh wrote:
> > > > > > ZijunZhao wrote:
> > > > > > > enh wrote:
> > > > > > > > hiraditya wrote:
> > > > > > > > > seems like we don't have a -std=gnu23, or -std=c23 standard flag for this in clang yet.
> > > > > > > > > 
> > > > > > > > > https://godbolt.org/z/7dKnGEWWE
> > > > > > > > > 
> > > > > > > > > we probably need it before testing stdckdint i guess?
> > > > > > > > other headers just use > and the previous version. (though see stdalign.h if you're looking for some random cleanup to do!)
> > > > > > > > seems like we don't have a -std=gnu23, or -std=c23 standard flag for this in clang yet.
> > > > > > > 
> > > > > > > In the local testing, `-std=c++23` works  and all tests pass😂 
> > > > > > > 
> > > > > > > 
> > > > > > C23 != C++23... they don't even really coordinate with one another... talk to hboehm about that some time :-)
> > > > > ohhh I think `gnu++23` != `gnu23` either 😂 
> > > > correct. the "c" or "c++" part means "standard stuff" and replacing it with "gnu" or "gnu++" means "standard stuff _and_ extensions".
> > > I try to grep "std>" in `clang/test/Headers` but find nothing, and nothing in stdalign.h is about `>`
> > This isn't a GNU feature, so we don't need to enable a GNU mode or set a gnu version. (Note, the file should be a .c file, not a .cpp file)
> Do we have plans to add -std=c23 anytime soon? `-std=c2x` defines `__STDC_VERSION__ 202000L`
> Do we have plans to add -std=c23 anytime soon? -std=c2x defines __STDC_VERSION__ 202000L

We needed to wait for WG14 to finalize the standard before we could decide what name to use or what macro value to pick. Both are settled now, so I plan to make those changes Sometime Soon™ 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157331/new/

https://reviews.llvm.org/D157331