[PATCH] D157201: [Clang] Support qualified name as member designator in offsetof

[Corentin Jabot via Phabricator via cfe-commits]

cor3ntin added inline comments.


================
Comment at: clang/include/clang/Sema/Sema.h:6038
     SourceLocation LocStart, LocEnd;
     bool isBrackets;  // true if [expr], false if .ident
+    bool isQualifier;
----------------
aaron.ballman wrote:
> I think we should combine `isBrackets` and `isQualifier` since a component can't be both at the same time anyway. e.g.,
> ```
> enum {
>   Brackets,   // U.E is valid
>   Identifier, // U.IdentInfo is valid
>   Qualifier,  // Nothing in U is valid
> } Kind;
> ```
This are not the best names.

ArrayElement, Subobject, NestedNameQualifier

Are probably more descriptive.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157201/new/

https://reviews.llvm.org/D157201