[PATCH] D156604: [clang][ExprConst] Use call source range for 'in call to' diags

Wed Aug 9 02:08:46 PDT 2023

tbaeder added a comment.

In D156604#4572018 <https://reviews.llvm.org/D156604#4572018>, @hazohelet wrote:

> We need some tests for dtors because they are handled differently from other functions.
> I think the current ExprConstant part would not cover the explicitly-called dtors because the `HandleDestructorImpl` only has access to `CallLoc` and not source range.
> Also new interpreter seems to point to the wrong source location on implicitly-called dtor.
> Link: https://godbolt.org/z/1a6GW47eG
> I think it's good to have a fix for it in this patch if it's not too complicated.

Yeah I know, there's a FIXME comment in the tests somewhere and it's on my list.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156604/new/

https://reviews.llvm.org/D156604