[PATCH] D157476: [RISCV] Fix wrong type prototype of RVVSlideOneBuiltinSet
Wang Pengcheng via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Aug 9 02:01:15 PDT 2023
wangpc added a comment.
In D157476#4572135 <https://reviews.llvm.org/D157476#4572135>, @eopXD wrote:
> I mean
>
> vint8mf8_t test_vslide1up_vx_i8mf8(vint8mf8_t src, int8_t value, size_t vl) {
> return __riscv_vslide1up_vx_i8mf8(src, value, vl);
> }
>
> should change into
>
> vint8mf8_t test_vslide1up_vx_i8mf8(vint8mf8_t src, uint8_t value, size_t vl) {
> return __riscv_vslide1up_vx_i8mf8(src, value, vl);
> }
Why need we pass unsigned integer when the vector elements are signed? Am I missing something here?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157476/new/
https://reviews.llvm.org/D157476
More information about the cfe-commits
mailing list