[PATCH] D157331: [clang] Implement C23 <stdckdint.h>

[Elliott Hughes via Phabricator via cfe-commits]

enh added inline comments.


================
Comment at: clang/test/Headers/stdckdint.cpp:1
+// RUN: %clang_cc1 -emit-llvm -fgnuc-version=4.2.1 -std=gnu++11 %s -o - | FileCheck %s
+
----------------
ZijunZhao wrote:
> enh wrote:
> > ZijunZhao wrote:
> > > enh wrote:
> > > > hiraditya wrote:
> > > > > seems like we don't have a -std=gnu23, or -std=c23 standard flag for this in clang yet.
> > > > > 
> > > > > https://godbolt.org/z/7dKnGEWWE
> > > > > 
> > > > > we probably need it before testing stdckdint i guess?
> > > > other headers just use > and the previous version. (though see stdalign.h if you're looking for some random cleanup to do!)
> > > > seems like we don't have a -std=gnu23, or -std=c23 standard flag for this in clang yet.
> > > 
> > > In the local testing, `-std=c++23` works  and all tests pass😂 
> > > 
> > > 
> > C23 != C++23... they don't even really coordinate with one another... talk to hboehm about that some time :-)
> ohhh I think `gnu++23` != `gnu23` either 😂 
correct. the "c" or "c++" part means "standard stuff" and replacing it with "gnu" or "gnu++" means "standard stuff _and_ extensions".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157331/new/

https://reviews.llvm.org/D157331