[PATCH] D157432: [clang][ConstExprEmitter] handle Unary Not on integers

Nick Desaulniers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 8 13:22:12 PDT 2023


nickdesaulniers added inline comments.


================
Comment at: clang/lib/CodeGen/CGExprConstant.cpp:1402
+    return nullptr;
+  }
+
----------------
A lot of these visitor methods for UnaryOperator are going to look almost the same; I think I might prefer to have a `VisitUnaryOperator` method instead, and simply switch on the kind of operator.

But perhaps, I should flush out more of these methods, then do such refactoring?  WDYT @efriedma 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157432/new/

https://reviews.llvm.org/D157432



More information about the cfe-commits mailing list