[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

Tue Aug 8 13:21:18 PDT 2023

aaron.ballman added a comment.

In D153536#4570561 <https://reviews.llvm.org/D153536#4570561>, @vitalybuka wrote:

> In D153536#4570534 <https://reviews.llvm.org/D153536#4570534>, @aaron.ballman wrote:
>
>> In D153536#4570513 <https://reviews.llvm.org/D153536#4570513>, @vitalybuka wrote:
>>
>>> This patch brakes https://lab.llvm.org/buildbot/#/builders/168/builds/14997
>>> Not sure what is wrong there, probably the test need to be updated. Can you please take a look?
>>
>> I'm a bit confused -- the linked bot is green and the failures to either side of the linked run are both failing for the same reason (which seems to be unrelated to the changes in this patch). It looks like this bot went red here: https://lab.llvm.org/buildbot/#/builders/168/builds/14944 and hasn't reliably come back to green.
>
> Sorry copy-pasted wrong url. This green is manual request on revision before this patch.
>
> Correct failure https://lab.llvm.org/buildbot/#/builders/168/builds/14944
> So it's persistently red after that.
>
> If anyone wondering, I've bisected to this patch on buildbot host.
> For whatever reason does not reproduce on my workstation.

Thanks! We might need someone from clangd to help here. The logs do not have any information explaining what's failing with the test, and looking at the test code, I struggle to see how these changes would impact that test. We've had some significant issues with flaky clangd tests (https://github.com/clangd/clangd/issues/1712), so it's possible this is happenstance.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153536/new/

https://reviews.llvm.org/D153536