[PATCH] D155387: [Clang] Fix member lookup so that we don't ignore ambiguous lookups in some cases

James Y Knight via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 8 12:11:01 PDT 2023


jyknight added a comment.

In D155387#4557834 <https://reviews.llvm.org/D155387#4557834>, @hctim wrote:

> I found an issue with building Android using this patch. I've reduced it down to the following problem where the evaluation of the `std::visit` is believed to be non-exhaustive, but it seems like it is? Would you mind taking a look? Admittedly, my knowledge in this area of the cxx stdlib is not so great.

Your example code is invalid, and Clang is now correctly diagnosing that. You can fix the problem by adding `using V::operator()...;` inside `struct Visitor`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155387/new/

https://reviews.llvm.org/D155387



More information about the cfe-commits mailing list