[PATCH] D157384: [clang] Added Attr::getVariety function

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 8 09:08:58 PDT 2023


aaron.ballman added inline comments.


================
Comment at: clang/include/clang/AST/Attr.h:87-99
+  enum class Variety {
+    None,
+    GNU,          // __attribute__((...))
+    Declspec,     // __declspec(...)
+    Microsoft,    // [...]
+    CXX11,        // [[...]]
+    C2x,          // [[...]]
----------------
I don't think either of these are needed -- `Attr` inherits from `AttributeCommonInfo` and that base class already has `AttributeCommonInfo::getSyntax()` for getting this information. Will that work for your needs?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157384/new/

https://reviews.llvm.org/D157384



More information about the cfe-commits mailing list