[PATCH] D156537: [CodeGen] Keep track of eagerly emitted globals

Tue Aug 8 02:32:02 PDT 2023

Hahnfeld added a comment.

In D156537#4554413 <https://reviews.llvm.org/D156537#4554413>, @v.g.vassilev wrote:

> In D156537#4554052 <https://reviews.llvm.org/D156537#4554052>, @Hahnfeld wrote:
>
>> @v.g.vassilev do we have a means to detect this case? In D156897 <https://reviews.llvm.org/D156897>, I'm refactoring all accesses to `EmittedDeferredDecl` to go via `addEmittedDeferredDecl`, so we should just add an early return when not emitting for a REPL.
>
> We have `getLangOpts().IncrementalExtensions`. Does that work?

Perfect! After D157379 <https://reviews.llvm.org/D157379>, calling `addEmittedDeferredDecl` should immediately return in case we are not in incremental mode.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156537/new/

https://reviews.llvm.org/D156537