[PATCH] D156320: [FLang] Add support for Rpass flag

Tue Aug 8 01:56:44 PDT 2023

victorkingi added a comment.

In D156320#4560839 <https://reviews.llvm.org/D156320#4560839>, @awarzynski wrote:

> Hey @victorkingi , thank you for working on this :)
>
> There's quite a lot going on here and I am thinking that it might be good to split this into a few patches? Also, please note that Flang's driver, unlike Clang, uses MLIR's coding style (use `camelCase` instead of `CamelCase`).
>
>> A StandaloneBackendConsumer was implemented but the DiagnosticsEngine still doesn't print to console the remarks produced.
>
> This could mean that it's not being deconstructed correctly. Or that it requires explicit flushing. Can you verify that it contains the expected remarks?

Hi @awarzynski thanks for the comments. Splitting it up makes sense, I will do that.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156320/new/

https://reviews.llvm.org/D156320