[PATCH] D157331: [clang] Implement C23 <stdckdint.h>
Aditya Kumar via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Aug 7 15:11:48 PDT 2023
hiraditya added inline comments.
================
Comment at: clang/lib/Headers/stdckdint.h:1
+/*===---- stdckdint.h - Standard header for checking integer
+ *-------------------------===
----------------
nit: format.
================
Comment at: clang/test/Headers/stdckdint.cpp:1
+// RUN: %clang_cc1 -emit-llvm -fgnuc-version=4.2.1 -std=gnu++11 %s -o - | FileCheck --check-prefix=CHECK-NEXT %s
+
----------------
1. nit: `-emit-llvm -fgnuc-version=4.2.` has two spaces.
2. please chose a prefix other than `CHECK-NEXT`. as it has special meaning. https://llvm.org/docs/CommandGuide/FileCheck.html#the-check-next-directive
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157331/new/
https://reviews.llvm.org/D157331
More information about the cfe-commits
mailing list