[PATCH] D157334: [clang] Define _MSC_EXTENSIONS on -gnu if -fms-extensions is set

Aiden Grossman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 7 14:51:32 PDT 2023


aidengrossman added reviewers: aaron.ballman, hans, mstorsjo, rnk, glandium.
aidengrossman added a comment.

This should fix the issues seen in https://reviews.llvm.org/D150646 regarding `-fms-extensions` being set on MinGW and the builtins being defined but no `_MSC_EXTENSIONS` macro being set which caused a redefinition of the `__cpuidex` function. I'm not sure if this is 100% correct, but at least something needs to be done when `-fms-extensions` is passed and the target triple includes `-gnu`. Also not sure what happened with the patch formatting in Phabricator. The git diff is much cleaner.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157334/new/

https://reviews.llvm.org/D157334



More information about the cfe-commits mailing list