[PATCH] D157324: [clang] Move the Clang CI jobs off of the libc++ builders

Louis Dionne via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 7 13:25:45 PDT 2023


ldionne created this revision.
Herald added a subscriber: JDevlieghere.
Herald added a project: All.
ldionne requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

The libc++ builders do not have the capacity to serve both libc++ and
Clang CI needs. We initially used the libc++ builders when adding
pre-commit CI for Clang as an experiment, however this setup has been
problematic for libc++ for a long time. It makes libc++ CI turnaround
way too slow, which has been a frequent source of frustration.

We didn't want to make this change before the release to avoid rocking
the boat too much in such an important time, however now that the
release has been cut, we need to make this change. This will shift
the traffic for Clang pre-commit CI from the libc++ builders to the
builders that have been used for Clang pre-commit CI defined outside
of Clang's BuildKite pipeline.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D157324

Files:
  clang/utils/ci/buildkite-pipeline.yml


Index: clang/utils/ci/buildkite-pipeline.yml
===================================================================
--- clang/utils/ci/buildkite-pipeline.yml
+++ clang/utils/ci/buildkite-pipeline.yml
@@ -22,8 +22,7 @@
       - "clang/utils/ci/run-buildbot check-format"
 
     agents:
-      queue: "libcxx-builders"
-      os: "linux"
+      queue: "linux"
     retry:
       automatic:
         - exit_status: -1  # Agent was lost
@@ -39,8 +38,7 @@
         CC: "clang-${LLVM_HEAD_VERSION}"
         CXX: "clang++-${LLVM_HEAD_VERSION}"
     agents:
-      queue: "libcxx-builders"
-      os: "linux"
+      queue: "linux"
     retry:
       automatic:
         - exit_status: -1  # Agent was lost
@@ -49,7 +47,7 @@
 
   - wait
 
-  - label: "C++03"
+  - label: "Running libc++ test suite in C++03"
     commands:
       - "clang/utils/ci/run-buildbot generic-cxx03"
     artifact_paths:
@@ -59,15 +57,14 @@
         LLVM_SYMBOLIZER_PATH: "/usr/bin/llvm-symbolizer-${LLVM_HEAD_VERSION}" # TODO: Should we build that from scratch?
         CLANG_CRASH_DIAGNOSTICS_DIR: "crash_diagnostics"
     agents:
-      queue: "libcxx-builders"
-      os: "linux"
+      queue: "linux"
     retry:
       automatic:
         - exit_status: -1  # Agent was lost
           limit: 2
     timeout_in_minutes: 120
 
-  - label: "C++26"
+  - label: "Running libc++ test suite in C++26"
     commands:
       - "clang/utils/ci/run-buildbot generic-cxx26"
     artifact_paths:
@@ -77,15 +74,14 @@
         LLVM_SYMBOLIZER_PATH: "/usr/bin/llvm-symbolizer-${LLVM_HEAD_VERSION}" # TODO: Should we build that from scratch?
         CLANG_CRASH_DIAGNOSTICS_DIR: "crash_diagnostics"
     agents:
-      queue: "libcxx-builders"
-      os: "linux"
+      queue: "linux"
     retry:
       automatic:
         - exit_status: -1  # Agent was lost
           limit: 2
     timeout_in_minutes: 120
 
-  - label: "Modules"
+  - label: "Running libc++ test suite with Clang Modules"
     commands:
       - "clang/utils/ci/run-buildbot generic-modules"
     artifact_paths:
@@ -95,8 +91,7 @@
         LLVM_SYMBOLIZER_PATH: "/usr/bin/llvm-symbolizer-${LLVM_HEAD_VERSION}" # TODO: Should we build that from scratch?
         CLANG_CRASH_DIAGNOSTICS_DIR: "crash_diagnostics"
     agents:
-      queue: "libcxx-builders"
-      os: "linux"
+      queue: "linux"
     retry:
       automatic:
         - exit_status: -1  # Agent was lost


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D157324.547927.patch
Type: text/x-patch
Size: 2399 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230807/7d6e8e25/attachment.bin>


More information about the cfe-commits mailing list