[PATCH] D154559: [clang] Fix constant evaluation about static member function

Richard Smith - zygoloid via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 7 11:32:18 PDT 2023


rsmith requested changes to this revision.
rsmith added a comment.
This revision now requires changes to proceed.

Clang was correct here until fairly recently; P2280 <https://reviews.llvm.org/P2280> (https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2022/p2280r4.html) changed the language rules. It was applied as a DR, so we should make that change retroactively rather than only in C++23 mode. See https://github.com/llvm/llvm-project/issues/63139, which tracks implementation of that language change.

I don't think we should be applying an ad-hoc patch like this which doesn't follow either the old or the new language rule, and should instead implement the new rule from P2280 <https://reviews.llvm.org/P2280>.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D154559/new/

https://reviews.llvm.org/D154559



More information about the cfe-commits mailing list