[PATCH] D142609: [Clang] Fix -Wconstant-logical-operand when LHS is a constant

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added subscribers: porglezomp, cjdb.
aaron.ballman added a comment.

Concerns have been raised in https://github.com/llvm/llvm-project/issues/64356 that this is an undesirable change in diagnostic behavior. The diagnostic is supposed to fire when misusing a logical operand that most likely should have been a bitwise operand. There's a feeling that `true && expr` is plausibly done intentionally more often than `true & expr`.

I think we should revert the changes from this patch and in the Clang 17.x branch so that we can reevaluate the approach taken in this patch. CC @porglezomp @cjdb


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142609/new/

https://reviews.llvm.org/D142609