[PATCH] D157269: [Clang][AArch64] Diagnostics for SME attributes when target doesn't have 'sme'

[Richard Sandiford via Phabricator via cfe-commits]

rsandifo-arm added a comment.

LGTM in terms of intent.



================
Comment at: clang/lib/Sema/SemaDecl.cpp:12092
+               diag::err_sme_definition_using_sm_in_non_sme_target);
+        if (UsesZA)
+          Diag(NewFD->getLocation(),
----------------
Suggest making this an `else if`.  We only need to give one error for a call to a streaming shared-ZA function, since the underlying error is the same.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157269/new/

https://reviews.llvm.org/D157269