[PATCH] D157238: [clang][ASTImporter] Add import of 'DependentSizedExtVectorType'
Ding Fei via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Aug 7 07:39:05 PDT 2023
danix800 added a comment.
In D157238#4565442 <https://reviews.llvm.org/D157238#4565442>, @balazske wrote:
> In D157238#4565260 <https://reviews.llvm.org/D157238#4565260>, @danix800 wrote:
>
>> In D157238#4565051 <https://reviews.llvm.org/D157238#4565051>, @balazske wrote:
>>
>>> `ASTImporter` part looks good, I did not check the generated documentation for correctness.
>>
>> Matcher part will be committed in https://reviews.llvm.org/D157237, these code is added here only to support this revision.
>
> It is possible to add D157237 <https://reviews.llvm.org/D157237> as parent revision (and upload code here without changes in D157237 <https://reviews.llvm.org/D157237>). It is more safe to have the exact same code in the review that will be committed.
This revision is cleaned up since D157237 <https://reviews.llvm.org/D157237> is already landed. For future revison I'll try these techniques to reduce reviewing burden. Thanks for reminding.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157238/new/
https://reviews.llvm.org/D157238
More information about the cfe-commits
mailing list