[PATCH] D157249: [clang][ASTImporter] Add import of 'ConvertVectorExpr'

Ding Fei via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 7 07:11:03 PDT 2023


danix800 added a comment.

In D157249#4565580 <https://reviews.llvm.org/D157249#4565580>, @aaron.ballman wrote:

>> Depends on https://reviews.llvm.org/D157248
>
> FWIW, this would usually be done via a "patch stack": https://kurtisnusbaum.medium.com/stacked-diffs-keeping-phabricator-diffs-small-d9964f4dcfa6 so that it's clear which changes are part of this patch and which changes are part of the parent patch.

I'll update this and D157238 <https://reviews.llvm.org/D157238> to clean state since their dependents are both landed.

For future revisions I'll try this "patch stack" if dependency exists.

Thanks for this info.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157249/new/

https://reviews.llvm.org/D157249



More information about the cfe-commits mailing list