[PATCH] D156928: [Clang][AMDGPU] Fix handling of -mcode-object-version=none arg

Mon Aug 7 06:04:13 PDT 2023

saiislam added a comment.

In D156928#4565506 <https://reviews.llvm.org/D156928#4565506>, @jhuber6 wrote:

> In D156928#4562239 <https://reviews.llvm.org/D156928#4562239>, @JonChesterfield wrote:
>
>> Or, the front end could define those objects directly, without importing IR files that define the objects with the content clang used to choose the object file. E.g. instead of the argument daz=off (spelled differently) finding a file called daz.off.ll that defines variable called daz with a value 0, that argument could define that variable. I think @jhuber6 has a partial patch trying to do that.
>>
>> If we were more ambitious, we could use intrinsics that are folded reliably at O0 instead of magic variables that hopefully get constant folded. That would kill a bunch of O0 bugs.
>>
>> In general though, splicing magic variables in the front end seems unlikely to be performance critical relative to splicing them in at the start of the backend.
>
> I think @saiislam is working on a patch that will handle that. We'll have `clang` emit some global that OpenMP uses.

Thanks Joseph.
Yes, I have abandoned this patch and using `-Xclang -mcode-object-version=none` option in the patch to enable cov5 support for OpenMP. <https://reviews.llvm.org/D139730>

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156928/new/

https://reviews.llvm.org/D156928