[PATCH] D157090: [Flang][Sema] Move directive sets to a shared location

[Sergio Afonso via Phabricator via cfe-commits]

skatrak added a comment.

In D157090#4562088 <https://reviews.llvm.org/D157090#4562088>, @kiranchandramohan wrote:

> This looks OK. The only concern is whether we will lose the ability to inline the code for set membership. Can these sets be put in a header file with `inline constexpr`?

Thank you for the suggestion. It's not possible to declare these as `constexpr` because `EnumSet::set`, called by the constructor, is not `constexpr` as well. But I have made them `const inline` and defined them in the header file. I hope that addresses your concerns.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157090/new/

https://reviews.llvm.org/D157090