[PATCH] D157190: [clang-tidy] Fixed false-negative in readability-identifier-naming

Piotr Zegar via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Aug 5 08:18:21 PDT 2023


PiotrZSL added inline comments.


================
Comment at: clang-tools-extra/test/clang-tidy/checkers/readability/identifier-naming.cpp:716
+// CHECK-FIXES: {{^}}class CClassWithForwardDecl {
+class class_with_forward_decl {
+  int __value;
----------------
carlosgalvezp wrote:
> Nit: shouldn't we use also `struct` here? 
No, thats on prupose. I wanted to test also in same place that style is taken from definition, not forward declaration, can add some comment, and "public:"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157190/new/

https://reviews.llvm.org/D157190



More information about the cfe-commits mailing list