[PATCH] D157185: [clang-tidy] Fix false-positives in performanc-noexcept-swap
Carlos Galvez via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sat Aug 5 08:09:52 PDT 2023
carlosgalvezp accepted this revision.
carlosgalvezp added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang-tools-extra/clang-tidy/performance/NoexceptSwapCheck.cpp:22
Finder->addMatcher(
- functionDecl(unless(isDeleted()), hasName("swap")).bind(BindFuncDeclName),
+ functionDecl(
+ unless(isDeleted()), hasName("swap"),
----------------
Would be good to add a small comment summarizing what signatures this block of code matches, for easier readability.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D157185/new/
https://reviews.llvm.org/D157185
More information about the cfe-commits
mailing list