[PATCH] D157066: [clang][modules][deps] Create more efficient API for visitation of `ModuleFile` inputs

Ben Langmuir via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 4 15:33:39 PDT 2023


benlangmuir accepted this revision.
benlangmuir added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/include/clang/Serialization/ModuleFile.h:72
+  bool TopLevel;
+  bool ModuleMap;
 };
----------------
jansvoboda11 wrote:
> benlangmuir wrote:
> > Is there something using this new split? It seems like every user is using `&&` for these
> You're right. I recall needing this on (now probably abandoned) patch, so I thought I might as well add the extra bit now, sine I'm changing the format anyways. I'm fine with removing this.
It's fine, I was just making sure I didn't miss something.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157066/new/

https://reviews.llvm.org/D157066



More information about the cfe-commits mailing list