[PATCH] D157115: Revert "[clang][X86] Add __cpuidex function to cpuid.h"

[Martin Storsjö via Phabricator via cfe-commits]

mstorsjo added a comment.

In D157115#4561497 <https://reviews.llvm.org/D157115#4561497>, @aaron.ballman wrote:

> Thank you for this! The revert LGTM, but please wait for @mstorsjo to confirm this won't cause problems for MinGW folks.

I guess this is fine.

We should probably sync mingw-w64 and revert https://github.com/mingw-w64/mingw-w64/commit/2b6c9247613aa830374e3686e09d3b8d582a92a6 after that. There's less rush in reverting it though (not many projects use `__cpuidex` so it's not so bad to not have it defined it at all - while having a double conflicting definition is fatal), but I guess I should update it at least once the 17.0.0 release gets closer and we see where we're settled (maybe bump the version threshold to 18 instead of 17, if we're somewhat sure we'll have it in main even if it's reverted in 17.x).

For mingw, I'd at least appreciate if we don't switch it back and forth further on the 17.x release branch after 17.0.0 is released.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157115/new/

https://reviews.llvm.org/D157115