[PATCH] D156320: [FLang] Add support for Rpass flag

Andrzej Warzynski via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 4 08:19:06 PDT 2023


awarzynski added a comment.

Hey @victorkingi , thank you for working on this :)

There's quite a lot going on here and I am thinking that it might be good to split this into a few patches? Also, please note that Flang's driver, unlike Clang, uses MLIR's coding style (use `camelCase` instead of `CamelCase`).

> A StandaloneBackendConsumer was implemented but the DiagnosticsEngine still doesn't print to console the remarks produced.

This could mean that it's not being deconstructed correctly. Or that it requires explicit flushing. Can you verify that it contains the expected remarks?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156320/new/

https://reviews.llvm.org/D156320



More information about the cfe-commits mailing list