[PATCH] D157028: [llvm] Extract common `OptTable` bits into macros

Thu Aug 3 19:22:34 PDT 2023

MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

In D157028#4558724 <https://reviews.llvm.org/D157028#4558724>, @jansvoboda11 wrote:

> Here's an example of a patch that changes the `OPTION` macro: D157029 <https://reviews.llvm.org/D157029>. I wonder if we could have counterparts to `LLVM_MAKE_OPT_ID` and `LLVM_CONSTRUCT_OPT_INFO` that allow overriding the default `OPT_` prefix. That would make D157029 <https://reviews.llvm.org/D157029> even smaller. WDYT @MaskRay?

The `#define OPTION(...) LLVM_MAKE_OPT_ID_WITH_ID_PREFIX(COFF_OPT_, __VA_ARGS__),` use case looks good:)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D157028/new/

https://reviews.llvm.org/D157028