[PATCH] D74094: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

Thu Aug 3 16:01:16 PDT 2023

jroelofs added a subscriber: lei.
jroelofs added a comment.

In D74094#4559037 <https://reviews.llvm.org/D74094#4559037>, @dexonsmith wrote:

> In D74094#4554327 <https://reviews.llvm.org/D74094#4554327>, @foad wrote:
>
>> Hi @erik.pilkington, I see this got reverted:
>
> I'm not sure if @erik.pilkington is still watching Phabricator, but in any case I think (like me) he no longer has rdar access. Since this was a Linux PPC bot, it's possible Erik didn't get far investigating the failure. Three years later, the sands may have shifted substantially... maybe the best option to is rebase and investigate the new failures (if any).
>
> @akyrtzi @arphaman @jroelofs, is one of you available to check rdar://58552124, in case it has extra context from the PPC bot failure?

I found rdar://59400672&60009515, which track the revert and reminder to investigate.  Neither go into any more detail on how/why it broke that bot, unfortunately.  I also found https://reviews.llvm.org/rGfafc6e4fdf3673dcf557d6c8ae0c0a4bb3184402 has a tiny bit more context than this review.  Maybe @lei can share the reproducer mentioned in that thread?  Otherwise, as Duncan said, I think your best bet is to try to re-land and see what breaks.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74094/new/

https://reviews.llvm.org/D74094