[PATCH] D156506: [clang][Interp] Check floating results for NaNs

Timm Bäder via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 3 10:21:26 PDT 2023


tbaeder added inline comments.


================
Comment at: clang/lib/AST/Interp/Interp.cpp:503
+  //   If during the evaluation of an expression, the result is not
+  //   mathematically defined [...], the behavior is undefined.
+  // FIXME: C++ rules require us to not conform to IEEE 754 here.
----------------
@jcranmer-intel Doesn't this comment (which I've coped from `ExprConstant.cpp`) contradict what you said about not checking the result?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D156506/new/

https://reviews.llvm.org/D156506



More information about the cfe-commits mailing list