[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added a comment.

In D153536#4556485 <https://reviews.llvm.org/D153536#4556485>, @cor3ntin wrote:

> From yesterday's C++ clang WG meeting
>
> - We can land this now
> - We need to track the debugger issue
> - We should mention the lack of debugging support in the release notes
> - We should strive to improve the situation in the 18 time frame but it would not be blocker as few people may be impacted.
> - We should remember to modify the release notes when debugger support is improved if that happens before clang 18

Agreed; there are some minor things that need to be tweaked before landing this now, but I think the patch is pretty close to finished.



================
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:4332
+      llvm::find_if(Result, [this](const NamedDecl *Elem) {
+        return (isa<FieldDecl>(Elem) || isa<IndirectFieldDecl>(Elem)) &&
+               Elem->isPlaceholderVar(getLangOpts());
----------------



================
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:4343
+      break;
+    if ((isa<FieldDecl>(ND) || isa<IndirectFieldDecl>(ND)) &&
+        ND->isPlaceholderVar(getLangOpts()))
----------------



================
Comment at: clang/lib/Sema/SemaDeclCXX.cpp:4355
+  for (auto *D : ClassDecl->lookup(MemberOrBase)) {
+    if (isa<FieldDecl>(D) || isa<IndirectFieldDecl>(D)) {
+      bool IsPlaceholder = D->isPlaceholderVar(getLangOpts());
----------------



================
Comment at: clang/www/cxx_status.html:148
   <td><a href="https://wg21.link/P2169R4">P2169R4</a></td>
-  <td class="none" align="center">No</td>
+  <td class="unreleased" align="center">Clang 17</td>
  </tr>
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153536/new/

https://reviews.llvm.org/D153536